Ticket #17 (closed enhancement: wontfix)

Opened 5 years ago

Last modified 2 years ago

add a disconnect method to XMPPClient

Reported by: tofu Owned by: ralphm
Priority: normal Milestone:
Component: generic Keywords:
Cc:

Description

It would be nice to have a method to disconnect and stop for the wokkel XMPPClient class.

Maybe something like the following : 

 def stop(self):
    self.xmlstream.sendFooter()
    self.stopService()
    reactor.stop()

Change History

comment:1 Changed 5 years ago by jack

There should probably be oen that does not stop the reactor as well. I can see where some service (like Punjab) might connect and disconnect many sub-services.

comment:2 Changed 5 years ago by tofu

  • branch set to branches/client-disconnect-17
  • author set to tofu

(In [131]) Branching to add a disconnect method to XMPPClient. re #17

comment:3 Changed 5 years ago by tofu

(In [132]) implemenet disconnect and stop, trying to think about the best way to test this. re #17

comment:4 Changed 2 years ago by ralphm

  • Status changed from new to closed
  • Resolution set to wontfix

This is partly also provided by stopService. I'm not convinced there should be any code in XMPPClient to stop the reactor. Closing.

Note: See TracTickets for help on using tickets.