Ticket #27 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

Patch to fix some issues with pubsub protocol compliance

Reported by: caedes Owned by: ralphm
Priority: normal Milestone: 0.5
Component: generic Keywords:
Cc: caedes, ralphm

Description

The patch handles two issues:

  • Made the create command include a configure node, required by the protocol.
  • Made delete command belong to owner pubsub namespace.

Attachments

pubsub.patch​ (2.0 KB) - added by caedes 5 years ago.
File fixing the pubsub errors, and the unit tests.

Change History

Changed 5 years ago by caedes

File fixing the pubsub errors, and the unit tests.

comment:1 Changed 5 years ago by ralphm

  • Cc caedes, ralphm added
  • Status changed from new to assigned
  • Milestone set to 0.5

Actually, the topic of an empty <configure/> element on node creation is being ​discussed on the pubsub mailinglist. At the very least it is a bug in the current version of the specification that this element is required for creating nodes.

As for the namespace of the delete element, yeah, that is indeed a bug in wokkel. Thanks for the patch.

comment:2 Changed 5 years ago by ralphm

(In [74]) Partially apply supplied patch by caedes, re #27.

comment:3 Changed 5 years ago by ralphm

  • Status changed from assigned to closed
  • Resolution set to fixed

(In [75]) Use correct namespace for delete node requests.

Author: caedes. Reviewer: ralphm. Fixes #27.

Note: See TracTickets for help on using tickets.