Ticket #34 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

Patch for small bug in wokkel.compat

Reported by: caedes Owned by: ralphm
Priority: normal Milestone:
Component: generic Keywords:
Cc:

Description

Attached patch fixes incorrectly testing for type in a function, when it should be stanzaType, thus making the test always true.

Attachments

wokkel_compat_fix.patch​ (373 bytes) - added by caedes 5 years ago.
fix error in wokkel.compat.toResponse

Change History

Changed 5 years ago by caedes

fix error in wokkel.compat.toResponse

comment:1 Changed 5 years ago by ralphm

  • branch set to branches/toResponse-stanzaType-34
  • author set to ralphm

(In [101]) Branching to 'toResponse-stanzaType-34'

comment:2 Changed 5 years ago by ralphm

I had coincidently found the same issue at the same time. I also opened the bug in Twisted itself: ​http://twistedmatrix.com/trac/ticket/3467.

comment:3 Changed 5 years ago by ralphm

  • Status changed from new to closed
  • Resolution set to fixed

(In [103]) Fix test for presence of stanzaType in toResponse.

Author: caedes, ralphm. Fixes #34.

Note: See TracTickets for help on using tickets.