Changeset 105:5d8f1609aaf3 for wokkel/test/test_pubsub.py

Timestamp:

Nov 9, 2011, 6:44:36 PM (11 years ago)

Author:

Ralph Meijer <ralphm@…>

Branch:

default

Children:

155:8b2ed9549399, 159:bbb746f79718

Message:

Allow wokkel.data_form.Form to be used as a read-only dict.

In [1334124db2fd] wokkel.pubsub.PubSubRequest.options was changed to be a
Form instead of dictionary, which makes existing code using that field to be
incompatible.

To reduce the impact of that change, this change implements various methods in
wokkel.data_form.Form to emulate a read-only dictionary. It now maps the
name of each field to its value, similar to the dictionary returned from
getValues. The latter is now identical to dict(form).

• * *

Address incompatible change concerning PubSubRequest?.options.

In changeset [1334124db2fd], PubSubRequest.options was changed to hold the
wokkel.data_form.Form that represents the data form sent in the original
request. This makes it easier to type check the form in a step separate from
parsing the request. However, this is an incompatible change.

To remedy this, we move the form to optionsForm and make options a property
that returns the values of the form.

File:

• wokkel/test/test_pubsub.py (modified) (3 diffs)

wokkel/test/test_pubsub.py

@@ -1618 +1618 @@
 
         request = pubsub.PubSubRequest.fromElement(parseXml(xml))
-        values = request.options.getValues()
+        values = request.options
         self.assertIn('pubsub#access_model', values)
         self.assertEqual(u'open', values['pubsub#access_model'])
@@ -2914 +2914 @@
         def configureSet(request):
             self.assertEquals(['pubsub#deliver_payloads'],
-                              request.options.fields.keys())
+                              request.options.keys())
 
         self.resource.getConfigurationOptions = getConfigurationOptions
@@ -3709 +3709 @@
 
         def setConfiguration(requestor, service, nodeIdentifier, options):
-            self.assertEquals({'pubsub#deliver_payloads': False,
-                               'pubsub#persist_items': True}, options)
-
+            self.assertIn('pubsub#deliver_payloads', options)
+            self.assertFalse(options['pubsub#deliver_payloads'])
+            self.assertIn('pubsub#persist_items', options)
+            self.assertTrue(options['pubsub#persist_items'])
 
         self.service.getConfigurationOptions = getConfigurationOptions