Ignore:
Timestamp:
Sep 2, 2011, 9:56:49 AM (11 years ago)
Author:
Ralph Meijer <ralphm@…>
Branch:
wokkel-muc-client-support-24
Message:

Improve UserPresence? parsing, clean up MUCClient, approach full test coverage.

  • Parse muc#user item elements from incoming presence.
  • Properly interpret status codes in muc#user extension; there can be more than one and they should be used as integers.
  • Give observers of responses to joins, leaves and nick changes a lower priority than the general presence observers inherited from PresenceProtocol?. This ensures that the Room/User? administration in MUCClient is processed before the deferred for these actions fire.
  • Use roomJID to create Room instances, instead of the separate roomIdentifier and server arguments. Also store this roomJID on the Room.
  • Change prototype for receivedSubject to include user argument.
  • Make several callback functions nested functions within the methods that use them, instead of method on the class itself.
File:
1 edited

Legend:

Unmodified
Added
Removed
  • wokkel/iwokkel.py

    r152 r153  
    779779    """
    780780
    781     def receivedSubject(room, subject):
     781    def receivedSubject(room, user, subject):
    782782        """
    783783        A subject is received when you join a room and when the subject is changed. This
     
    786786        @param room: The room the subject was accepted for.
    787787        @type room: L{muc.Room}
     788
     789        @param user: The user that set the subject.
     790        @type  user: L{muc.User}
    788791
    789792        @param subject: The subject of the given room.
Note: See TracChangeset for help on using the changeset viewer.