Changeset 88:58b00aeed1a6 for wokkel/test/test_pubsub.py

Timestamp:

Feb 25, 2010, 10:14:57 AM (11 years ago)

Author:

Ralph Meijer <ralphm@…>

Branch:

default

Message:

Service Discovery fixes for PubSubService?.

• PubSubService? now properly implements IDisco.
• Invalid returned values or exceptions raised by getInfo calls on PubSubResource? instances are now logged and ignored.

File:

• wokkel/test/test_pubsub.py (modified) (2 diffs)

wokkel/test/test_pubsub.py

@@ -1904 +1904 @@
 
 
+    def test_interfaceIDisco(self):
+        """
+        Do instances of L{pubsub.PubSubService} provide L{iwokkel.IDisco}?
+        """
+        verify.verifyObject(iwokkel.IDisco, self.service)
+
+
     def test_connectionMade(self):
         """
@@ -2006 +2013 @@
         d = self.service.getDiscoInfo(JID('user@example.org/home'),
                                       JID('pubsub.example.org'), '')
+        d.addCallback(cb)
+        return d
+
+
+    def test_getDiscoInfoBadResponse(self):
+        """
+        If getInfo returns invalid response, it should be logged, then ignored.
+        """
+        def cb(info):
+            self.assertEquals([], info)
+            self.assertEqual(1, len(self.flushLoggedErrors(TypeError)))
+
+        def getInfo(requestor, target, nodeIdentifier):
+            return defer.succeed('bad response')
+
+        self.resource.getInfo = getInfo
+        d = self.service.getDiscoInfo(JID('user@example.org/home'),
+                                      JID('pubsub.example.org'), 'test')
+        d.addCallback(cb)
+        return d
+
+
+    def test_getDiscoInfoException(self):
+        """
+        If getInfo returns invalid response, it should be logged, then ignored.
+        """
+        def cb(info):
+            self.assertEquals([], info)
+            self.assertEqual(1, len(self.flushLoggedErrors(NotImplementedError)))
+
+        def getInfo(requestor, target, nodeIdentifier):
+            return defer.fail(NotImplementedError())
+
+        self.resource.getInfo = getInfo
+        d = self.service.getDiscoInfo(JID('user@example.org/home'),
+                                      JID('pubsub.example.org'), 'test')
         d.addCallback(cb)
         return d