Changeset 153:bf4b940f3547 for wokkel/iwokkel.py

Timestamp:

Sep 2, 2011, 9:56:49 AM (11 years ago)

Author:

Ralph Meijer <ralphm@…>

Branch:

wokkel-muc-client-support-24

Message:

Improve UserPresence? parsing, clean up MUCClient, approach full test coverage.

• Parse muc#user item elements from incoming presence.
• Properly interpret status codes in muc#user extension; there can be more than one and they should be used as integers.
• Give observers of responses to joins, leaves and nick changes a lower priority than the general presence observers inherited from PresenceProtocol?. This ensures that the Room/User? administration in MUCClient is processed before the deferred for these actions fire.
• Use roomJID to create Room instances, instead of the separate roomIdentifier and server arguments. Also store this roomJID on the Room.
• Change prototype for receivedSubject to include user argument.
• Make several callback functions nested functions within the methods that use them, instead of method on the class itself.

File:

• wokkel/iwokkel.py (modified) (2 diffs)

wokkel/iwokkel.py

@@ -779 +779 @@
     """
 
-    def receivedSubject(room, subject):
+    def receivedSubject(room, user, subject):
         """
         A subject is received when you join a room and when the subject is changed. This
@@ -786 +786 @@
         @param room: The room the subject was accepted for.
         @type room: L{muc.Room}
+
+        @param user: The user that set the subject.
+        @type  user: L{muc.User}
 
         @param subject: The subject of the given room.