Openfire needs subscription-id passed for PubSub requests (items() specifically)

[rcoup]

So, currently if I call PubSubClient.items() hitting an Openfire 3.5.2 server I get a bad-request error (​Subscription ID required).

Maybe an extra kwarg to PubSubClient.items() to pass a subid attribute to the request? Or maybe its more generic and other requests need it too - I haven't really looked too deeply.

def items(self, service, nodeIdentifier, maxItems=None, subId=None):
  """
  Retrieve previously published items from a publish subscribe node. 
  ...
  """
  request = _PubSubRequest(self.xmlstream, 'items', method='get')
  request.command['node'] = nodeIdentifier
  if maxItems:
    request.command["max_items"] = str(int(maxItems))
  if subId:
    request.command["subid"] = subId

  ...

[ralphm]

[3fe44cf07366] added support for subscription identifiers. Closing.