Opened 14 years ago
Closed 13 years ago
#35 closed defect (wontfix)
wokkel/generic attempts to import non-existent toResponse
Reported by: | dustin | Owned by: | ralphm |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | generic | Keywords: | |
Cc: |
Description
In adding version support to a bot, I found a bad import in wokkel/generic. Looks like it's coming, but not here yet. In the meantime, compat seems to do it.
Attachments (1)
Change History (4)
Changed 14 years ago by dustin
comment:1 Changed 14 years ago by dustin
And, of course, not having to use subversion for this would be a huge win. :)
comment:2 Changed 14 years ago by ralphm
twisted.words.protocols.jabber.xmlstream has had toResponse since Twisted Words 8.0.0, which was released on 2008-03-17. I assume you are using the release before that, Twisted Words 0.5.0, released 2007-01-06. Wokkel 0.4.0 should still work with that version.
I have looked at what it takes to make the current trunk work on Twisted Words 0.5.0, but there was an API change in how authenticators work. To fix that, I would more or less need to import all of the changes to Twisted Words' Jabber support into wokkel, which is a bit much.
I am tempted to drop support for Twisted Words 0.5.0, as Twisted Words 8.2 will be released Real Soon Now™.
Is it safe to assume you use Debian stable and therefore have this old version of Twisted? In that case, I noticed that there is a backport of Twisted Words 8.0.0 for etch.
As for Subversion, I have been using Mercurial a lot lately, so I might set up a public Mercurial repository for Wokkel. But that is a discussion that could be had on the Twisted Jabber mailinglist.
Leaving this open for now, but likely marking this as wontfix when I make up my mind about Twisted Words 0.5.0 support.
comment:3 Changed 13 years ago by ralphm
- Resolution set to wontfix
- Status changed from new to closed
This was resolved by removing the backwards compatibility code for toResponse and depend on Twisted Words 8.0.0 or later in [165].
Import patch for wokkel/generic re: toResponse