Opened 11 years ago

Closed 8 years ago

#56 closed enhancement (fixed)

RosterClientProtocol should allow for item addition as well as item removal

Reported by: nathan Owned by: nathan
Priority: normal Milestone:
Component: generic Keywords:
Cc:

Description

RosterClientProtocol? currently only allows for roster items to be removed. An addItem method should be added to allow for the inverse.

Attachments (1)

patch (809 bytes) - added by nathan 11 years ago.

Download all attachments as: .zip

Change History (5)

Changed 11 years ago by nathan

comment:1 Changed 11 years ago by nathan

The attached patch adds the addItem method. Hopefully I can figure out a test to.

comment:2 Changed 10 years ago by ralphm

I can see the following issues with this patch:

  • No tests are provided.
  • There is no way to set the roster item's handle.
  • There is no way to set the groups the item should be in.

As it is currently written, all of its functionality is covered by sending a presence subscription request to the JID of the desired roster item. It is also suggested by the upcoming revision

to rfc:3921 to first send this presence subscription request before setting a roster item (just adding a JID to a roster without requesting presence is not very common).

comment:3 Changed 10 years ago by ralphm

Closed #50 as a duplicate.

comment:4 Changed 8 years ago by ralphm

  • Resolution set to fixed
  • Status changed from new to closed

(In [c0f51d95bf0f]:) Add support for adding and updating roster items.

Roster items can be added or updated by sending a roster set request using the new wokkel.xmppim.RosterClientProtocol.setItem. It takes a RosterItem as the only argument. Note that changes in presence subscriptions for the contact need to be done using presence as provided by wokkel.xmppim.PresenceProtocol.

Author: ralphm. Fixes: #56.

Note: See TracTickets for help on using tickets.