Opened 11 years ago
Closed 10 years ago
#70 closed defect (fixed)
PubSubService fails on unsupported features in the legacy handlers
| Reported by: | ralphm | Owned by: | ralphm |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | pubsub | Keywords: | |
| Cc: |
Description
As originally reported in idavoll:#16, PubSubService does not (yet) provide support some protocol features, like the owner use case of managing affiliations, which do have (some) support in PubSubRequest. When using PubSubResource, this returns a proper feature-not-implemented error stanza, but for the legacy interface a KeyError is raised, resulting in an internal-server-error.
Change History (2)
comment:1 Changed 10 years ago by ralphm
comment:2 Changed 10 years ago by ralphm
- Resolution set to fixed
- Status changed from new to closed
Note: See
TracTickets for help on using
tickets.
(In [c0473c62802d]) Catch KeyError for unsupported verbs in legacy PubSubService usage.
Author: ralphm. Fixes: #70.
Because requests are now parsed by PubSubRequest, it can happen that a request is successfully parsed, but there is no legacy handler available. This used to raise a KeyError, resulting in a internal-server-error being returned. Now it returns a feature-not-implemented error.