Opened 12 years ago

Closed 10 years ago

#71 closed defect (fixed)

Roster sets always fail in RosterClientProtocol

Reported by: ff Owned by: ralphm
Priority: normal Milestone:
Component: generic Keywords:
Cc:

Description

As discussed in this thread ​https://mailman.ik.nu/pipermail/twisted-jabber/2010-October/000341.html roster sets are always ignored since the test of the sender is wrong and it always fails

Change History (1)

comment:1 Changed 10 years ago by ralphm

  • Resolution set to fixed
  • Status changed from new to closed

(In [ea2774e1c71c]:) Clean up of RosterItem and RosterClientProtocol.

RosterItem:

  • Renamed attributes jid and ask to entity and pendingOut respectively.
  • Can represent roster items to be removed or that have been removed.
  • Now has fromElement and toElement methods.

RosterRequest is a new class to represent roster request stanzas.

RosterClientProtocol:

  • Roster returned from getRoster is now indexed by JIDs (instead of the unicode representation of the JID).
  • Outgoing requests are now done using RosterRequest.
  • onRosterSet and onRosterRemove are deprecated in favor of setReceived and removeReceived, respectively. These are called with a RosterRequest to have access to addressing and roster version information.

RosterPushIgnored can be raised to return a service-unavailable stanza error for unwanted pushes.

This also fixes a problem with checking the sender address for roster pushes.

Author: ralphm. Fixes: #71.

Note: See TracTickets for help on using tickets.