Opened 9 years ago

Closed 8 years ago

#73 closed defect (fixed)

KeyError in disco on IQ request without "to" or "from" attribute

Reported by: Goffi Owned by: ralphm
Priority: normal Milestone:
Component: disco Keywords:
Cc:

Description

G'day,

If we have a disco info request with no "to" or "from" attribute, a KeyError? exception is raised. This issue happen with Prosody server, and was discussed on the mailing list: ​http://www.mail-archive.com/twisted-jabber@ik.nu/msg00340.html .

The attached patch fix this issue.

cheers

Attachments (2)

disco.patch​ (702 bytes) - added by Goffi 9 years ago.
Path to fix KeyError? on disco request with no "to" or "from" attribute
test_disco.patch​ (3.2 KB) - added by Goffi 9 years ago.
Tests for handling of discoInfo request with no to and no from attribute

Download all attachments as: .zip

Change History (5)

Changed 9 years ago by Goffi

Path to fix KeyError? on disco request with no "to" or "from" attribute

Changed 9 years ago by Goffi

Tests for handling of discoInfo request with no to and no from attribute

comment:1 Changed 9 years ago by Goffi

Added some tests based on test_onDiscoInfo

comment:2 Changed 8 years ago by ralphm

This was fixed in [e17a30fe7144] by reimplemting _DiscoRequest using wokkel.generic.Request.

comment:3 Changed 8 years ago by ralphm

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.